kind of dependency resolver

right now plugin to plugin dependencies are not supported

CringePlugins/CringePlugins.csproj

@@ -22,14 +22,13 @@
     </ItemGroup>
     
     <ItemGroup>
-        <PackageReference Include="Basic.Reference.Assemblies.Net80" Version="1.7.9" PrivateAssets="all" />
-        <PackageReference Include="Basic.Reference.Assemblies.Net80Windows" Version="1.7.9" PrivateAssets="all" />
+        <PackageReference Include="Basic.Reference.Assemblies.Net90" Version="1.7.9" PrivateAssets="all" />
         <PackageReference Include="NLog" Version="5.3.4" />
         <PackageReference Include="Lib.Harmony.Thin" Version="2.3.4-torch" />
         <PackageReference Include="ImGui.NET.DirectX" Version="1.91.0.1" />
         <PackageReference Include="SpaceEngineersDedicated.ReferenceAssemblies" Version="1.*" ExcludeAssets="runtime" />
         <PackageReference Include="dnlib" Version="4.4.0" />
-        <PackageReference Include="Krafs.Publicizer" Version="2.2.1">
+        <PackageReference Include="Krafs.Publicizer" Version="2.3.0">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

CringePlugins/Loader/PluginsLifetime.cs

@@ -25,7 +25,7 @@ public class PluginsLifetime(string gameFolder) : ILoadingStage
     
     private ImmutableArray<PluginInstance> _plugins = [];
     private readonly DirectoryInfo _dir = Directory.CreateDirectory(Path.Join(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), "CringeLauncher"));
-    private readonly NuGetFramework _runtimeFramework = NuGetFramework.ParseFolder("net8.0-windows10.0.19041.0");
+    private readonly NuGetFramework _runtimeFramework = NuGetFramework.ParseFolder("net9.0-windows10.0.19041.0");
 
     public async ValueTask Load(ISplashProgress progress)
     {
@@ -89,35 +89,40 @@ public class PluginsLifetime(string gameFolder) : ILoadingStage
         Contexts = contextBuilder.ToImmutable();
     }
 
-    private async Task LoadPlugins(IReadOnlySet<CachedPackage> packages, PackageSourceMapping sourceMapping,
+    private async Task LoadPlugins(IReadOnlyCollection<CachedPackage> packages, PackageSourceMapping sourceMapping,
         PackagesConfig packagesConfig)
     {
         var plugins = _plugins.ToBuilder();
 
-        var packageVersions = BuiltInPackages.GetPackages(_runtimeFramework)
-            .ToImmutableDictionary(b => b.Package.Id, b => b.Package.Version,
-                StringComparer.OrdinalIgnoreCase);
-
-        packageVersions = packageVersions.AddRange(packages.Select(b =>
-            new KeyValuePair<string, NuGetVersion>(b.Package.Id, b.Package.Version)));
+        var builtInPackages = BuiltInPackages.GetPackages(_runtimeFramework)
+            .ToImmutableDictionary(package => package.Package.Id);
+        
+        var resolvedPackages = builtInPackages.ToDictionary();
+        foreach (var package in packages)
+        {
+            resolvedPackages.TryAdd(package.Package.Id, package);
+        }
 
         var manifestBuilder = new DependencyManifestBuilder(_dir.CreateSubdirectory("cache"), sourceMapping,
-            dependency => packageVersions.TryGetValue(dependency.Id, out var version) && version.Major != 99
-                ? version
-                : dependency.Range.MinVersion ?? dependency.Range.MaxVersion);
+            dependency =>
+            {
+                resolvedPackages.TryGetValue(dependency.Id, out var package);
+                return package?.Entry;
+            });
         
         foreach (var package in packages)
         {
+            if (builtInPackages.ContainsKey(package.Package.Id)) continue;
+            
             var dir = Path.Join(package.Directory.FullName, "lib", package.ResolvedFramework.GetShortFolderName());
 
             var path = Path.Join(dir, $"{package.Package.Id}.deps.json");
             if (!File.Exists(path))
             {
-                await using (var stream = File.Create(path))
-                    await manifestBuilder.WriteDependencyManifestAsync(stream, package.Entry, _runtimeFramework);
+                await using var stream = File.Create(path);
+                await manifestBuilder.WriteDependencyManifestAsync(stream, package.Entry, _runtimeFramework);
             }
             
-
             var client = await sourceMapping.GetClientAsync(package.Package.Id);
             var sourceName = packagesConfig.Sources.First(b => b.Url == client.ToString()).Name;
             LoadComponent(plugins, Path.Join(dir, $"{package.Package.Id}.dll"),

CringePlugins/Resolver/BuiltInPackages.cs

@@ -41,14 +41,14 @@ public static class BuiltInPackages
             var version = attribute is null ? new(99, 0, 0) : NuGetVersion.Parse((string)attribute.ConstructorArguments[0].Value);
             
             return new BuiltInSdkPackage(
-                new(0, Path.GetFileNameWithoutExtension(r.FileName), version, []), runtimeFramework,
+                new(0, Path.GetFileNameWithoutExtension(r.FileName), version), runtimeFramework,
                 new(Path.GetFileNameWithoutExtension(r.FileName), version, [new(runtimeFramework, [])], null, []));
         }
 
         return
         [
-            ..Net80.ReferenceInfos.AllValues.Select(MapSdkPackage),
-            ..Net80Windows.ReferenceInfos.AllValues.Select(MapSdkPackage),
+            ..Net90.ReferenceInfos.AllValues.Select(MapSdkPackage),
+            // ..Net80Windows.ReferenceInfos.AllValues.Select(MapSdkPackage),
             nlog,
             se,
             imGui,
@@ -72,7 +72,7 @@ public static class BuiltInPackages
         dependencies ??= [];
 
         return new(
-            new(0, id, version, [..dependencies.Value.Select(b => b.Id)]),
+            new(0, id, version),
             runtimeFramework,
             new(id, version, [
                 new(runtimeFramework, dependencies.Value)

CringePlugins/Resolver/PackageResolver.cs

@@ -11,7 +11,7 @@ namespace CringePlugins.Resolver;
 public class PackageResolver(NuGetFramework runtimeFramework, ImmutableArray<PackageReference> references, PackageSourceMapping packageSources)
 {
     private static readonly ILogger Log = LogManager.GetCurrentClassLogger();
-    public async Task<ImmutableHashSet<ResolvedPackage>> ResolveAsync()
+    public async Task<ImmutableSortedSet<ResolvedPackage>> ResolveAsync()
     {
         var order = 0;
         var packages = new SortedDictionary<Package, CatalogEntry>();
@@ -40,10 +40,12 @@ public class PackageResolver(NuGetFramework runtimeFramework, ImmutableArray<Pac
             
             if (version is null)
                 throw new Exception($"Unable to find version for package {reference.Id}");
+
+            var catalogEntry = items[version].CatalogEntry;
             
-            var package = new Package(order, reference.Id, version, []); // todo resolve dependencies
-            
-            if (packages.TryAdd(package, items[version].CatalogEntry))
+            var package = new Package(order, reference.Id, version);
+
+            if (packages.TryAdd(package, catalogEntry))
                 continue;
             
             if (!packages.TryGetValue(package, out _))
@@ -61,10 +63,10 @@ public class PackageResolver(NuGetFramework runtimeFramework, ImmutableArray<Pac
             packages.Add(package with
             {
                 Order = ++order
-            }, items[version].CatalogEntry);
+            }, catalogEntry);
         }
 
-        var set = ImmutableHashSet<ResolvedPackage>.Empty.ToBuilder();
+        var set = ImmutableSortedSet<ResolvedPackage>.Empty.ToBuilder();
         foreach (var (package, catalogEntry) in packages)
         {
             var client = await packageSources.GetClientAsync(package.Id);
@@ -80,6 +82,78 @@ public class PackageResolver(NuGetFramework runtimeFramework, ImmutableArray<Pac
 
             set.Add(new RemotePackage(package, nearestGroup.TargetFramework, client, catalogEntry));
         }
+        
+        for (var i = 0; i < set.Count; i++)
+        {
+            if (set[i] is not RemotePackage package) continue;
+
+            var dependencies = package.Entry.DependencyGroups
+                                   ?.Single(b => b.TargetFramework == package.ResolvedFramework)?.Dependencies ??
+                               [];
+            
+            foreach (var (id, versionRange) in dependencies)
+            {
+                var client = await packageSources.GetClientAsync(id);
+                
+                RegistrationRoot? registrationRoot;
+
+                try
+                {
+                    registrationRoot = await client.GetPackageRegistrationRootAsync(id);
+                }
+                catch (HttpRequestException ex)
+                {
+                    throw new Exception($"Failed to resolve dependency {id} for {package.Package}", ex);
+                }
+                
+                var items = registrationRoot.Items.SelectMany(page => page.Items!)
+                    .ToImmutableDictionary(b => b.CatalogEntry.Version);
+
+                var version = items.Values.Select(b => b.CatalogEntry.Version).OrderDescending().FirstOrDefault(b => versionRange.Satisfies(b));
+            
+                if (version is null)
+                    throw new Exception($"Unable to find version for package {id} as dependency of {package.Package}");
+                
+                var catalogEntry = items[version].CatalogEntry;
+
+                var dependencyPackage = new Package(i, id, version);
+
+                if (packages.TryGetValue(dependencyPackage, out var existingPackage))
+                {
+                    if (dependencyPackage.Version < existingPackage.Version)
+                    {
+                        // dependency has lower version than already resolved
+                        // need to check if existing fits the version range
+                        // and reorder existing to ensure it's ordered before requesting package
+
+                        if (!versionRange.Satisfies(existingPackage.Version))
+                            throw new Exception(
+                                $"Incompatible package version {dependencyPackage} (required by {package.Package}) from {existingPackage}");
+                        
+                        if (dependencyPackage.CompareTo(existingPackage) < 0)
+                        {
+                            packages.Remove(dependencyPackage);
+                            packages.Add(dependencyPackage, existingPackage);
+                        }
+                        
+                        continue;
+                    }
+                    
+                    throw new Exception($"Detected package downgrade from {existingPackage} to {dependencyPackage} as dependency of {package.Package}");
+                }
+                
+                if (!packages.TryAdd(dependencyPackage, catalogEntry))
+                    throw new Exception($"Duplicate package {dependencyPackage.Id}");
+                
+                var nearestGroup = NuGetFrameworkUtility.GetNearest(catalogEntry.DependencyGroups ?? [], runtimeFramework,
+                    g => g.TargetFramework);
+            
+                if (nearestGroup is null)
+                    throw new Exception($"Unable to find compatible dependency group for {dependencyPackage} as dependency of {package.Package}");
+                
+                set.Add(new RemoteDependencyPackage(dependencyPackage, nearestGroup.TargetFramework, client, package, catalogEntry));
+            }
+        }
 
         return set.ToImmutable();
     }
@@ -127,9 +201,40 @@ public class PackageResolver(NuGetFramework runtimeFramework, ImmutableArray<Pac
 public record CachedPackage(Package Package, NuGetFramework ResolvedFramework, DirectoryInfo Directory, CatalogEntry Entry) : ResolvedPackage(Package, ResolvedFramework, Entry);
 public record RemotePackage(Package Package, NuGetFramework ResolvedFramework, NuGetClient Client, CatalogEntry Entry) : ResolvedPackage(Package, ResolvedFramework, Entry);
 
-public abstract record ResolvedPackage(Package Package, NuGetFramework ResolvedFramework, CatalogEntry Entry);
+// should not inherit from RemotePackage
+public record RemoteDependencyPackage(
+    Package Package,
+    NuGetFramework ResolvedFramework,
+    NuGetClient Client,
+    RemotePackage Parent,
+    CatalogEntry Entry) : ResolvedPackage(Package, ResolvedFramework, Entry);
 
-public record Package(int Order, string Id, NuGetVersion Version, ImmutableArray<string> Dependencies) : IComparable<Package>, IComparable
+public abstract record ResolvedPackage(Package Package, NuGetFramework ResolvedFramework, CatalogEntry Entry) : IComparable<ResolvedPackage>, IComparable
+{
+    public int CompareTo(ResolvedPackage? other)
+    {
+        if (ReferenceEquals(this, other)) return 0;
+        if (other is null) return 1;
+        return Package.CompareTo(other.Package);
+    }
+
+    public int CompareTo(object? obj)
+    {
+        if (obj is null) return 1;
+        if (ReferenceEquals(this, obj)) return 0;
+        return obj is ResolvedPackage other ? CompareTo(other) : throw new ArgumentException($"Object must be of type {nameof(ResolvedPackage)}");
+    }
+
+    public override int GetHashCode() => Package.GetHashCode();
+
+    public virtual bool Equals(Package? other)
+    {
+        if (other is null) return false;
+        return Package.Equals(other);
+    }
+}
+
+public record Package(int Order, string Id, NuGetVersion Version) : IComparable<Package>, IComparable
 {
     public int CompareTo(Package? other)
     {

CringePlugins/packages.lock.json

@@ -2,20 +2,11 @@
   "version": 1,
   "dependencies": {
     "net9.0-windows7.0": {
-      "Basic.Reference.Assemblies.Net80": {
+      "Basic.Reference.Assemblies.Net90": {
         "type": "Direct",
         "requested": "[1.7.9, )",
         "resolved": "1.7.9",
-        "contentHash": "1wbS9ZJLFVrKD2jqv27gekIrpjpLffR9sitLQh5drWoG9KbyR/CgrAhw5I0c8Eq3zFMOToCmrpZi3VpRoInCgg==",
-        "dependencies": {
-          "Microsoft.CodeAnalysis.Common": "4.11.0"
-        }
-      },
-      "Basic.Reference.Assemblies.Net80Windows": {
-        "type": "Direct",
-        "requested": "[1.7.9, )",
-        "resolved": "1.7.9",
-        "contentHash": "98GFm8MC+pv37rTHaxBm5KFucqdJj0jK0XRHSGt2sXK9HNqtGImIFCFahxjUzskQjiUkPAzVhTou2OYZOuhhEg==",
+        "contentHash": "9CUkU6Z17tJL/cQc6FeZL0qfQf4CBaNpSBqFL6CTmrIC8827x7NEPyNq/inZA/r6Y5ziWo2Yd8caMxLPqDUpeA==",
         "dependencies": {
           "Microsoft.CodeAnalysis.Common": "4.11.0"
         }
@@ -39,9 +30,9 @@
       },
       "Krafs.Publicizer": {
         "type": "Direct",
-        "requested": "[2.2.1, )",
-        "resolved": "2.2.1",
-        "contentHash": "QGI4nMGQbKsuFUUboixVHu4mv3lHB5RejIa7toIlzTmwLkuCYYEpUBJjmy3OpXYyj5dVSZAXVbr4oeMSloE67Q=="
+        "requested": "[2.3.0, )",
+        "resolved": "2.3.0",
+        "contentHash": "DjktTgctwxUMhMkWKrRECer3LR1lHzanCOlE4mpinAiY8SfWJq4DG/QitP5h1A+WBjyWHzQSOG+204i3VpO1FA=="
       },
       "Lib.Harmony.Thin": {
         "type": "Direct",